Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ability to check out with Stripe while storing a new card #9585

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Restore ability to check out with Stripe while storing a new card #9585

merged 1 commit into from
Aug 24, 2022

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Aug 22, 2022 •
edited
Loading

This reverts #9456.

What? Why?

Closes #9580

What should we test?

  1. Log in as user.
  2. Add items to cart.
  3. Check out with Stripe and tick "Remember this card?".
  4. Submit with "Place order now".

Release notes

Changelog Category: User facing changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk self-assigned this Aug 22, 2022
@mkllnk mkllnk added the pr-staged-uk staging.openfoodnetwork.org.uk label Aug 22, 2022
@mkllnk
Revert "Merge pull request openfoodfoundation#9456 from openfoodfound…
7cb74f2 
…ation/dependabot/bundler/activemerchant-1.126.0"

This reverts commit 82f38c9, reversing
changes made to 689720b.
@mkllnk mkllnk force-pushed the revert-stripe-update branch from ee01b94 to 7cb74f2 Compare August 22, 2022 05:32
@mkllnk mkllnk removed the pr-staged-uk staging.openfoodnetwork.org.uk label Aug 22, 2022
@mkllnk mkllnk changed the title Revert "Merge pull request #9507 from openfoodfoundation/dependabot/bundler/stripe-7.0.0" Restore ability to check out with Stripe while storing a new card Aug 22, 2022
@mkllnk mkllnk marked this pull request as ready for review August 22, 2022 05:53
@mkllnk mkllnk requested a review from filipefurtad0 August 22, 2022 06:21
mkllnk
mkllnk commented Aug 24, 2022
View reviewed changes
Copy link
Member Author

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The production test was successful, so I'll merge this because it's a simple revert. Shouldn't need any further review.

@mkllnk mkllnk merged commit 8723520 into openfoodfoundation:master Aug 24, 2022
@mkllnk mkllnk deleted the revert-stripe-update branch August 24, 2022 23:52
@jibees jibees mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipefurtad0 filipefurtad0 Awaiting requested review from filipefurtad0

Assignees

@mkllnk mkllnk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stripe/active_merchant] Checkout error prevents order completion
1 participant
@mkllnk