Make the shop url clickable #9529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibees
suggested changes
Aug 8, 2022
Philwi
force-pushed
the
make-the-shop-url-clickable
branch
2 times, most recently
from
211730b to
0fa5c77
Compare
Philwi
force-pushed
the
make-the-shop-url-clickable
branch
from
0fa5c77 to
79c942d
Compare
|
Hey @Philwi , welcome! 🎉 There's a relevant failing spec on this PR:
It needs to be addressed before testing - moving to in Dev 👍 |
Philwi
force-pushed
the
make-the-shop-url-clickable
branch
2 times, most recently
from
911f253 to
f366239
Compare
Philwi
force-pushed
the
make-the-shop-url-clickable
branch
from
f366239 to
141a2a5
Compare
|
I guess this can go straight back to Test ready @filipefurtad0 ? |
|
Thanks @sigmundpetersen @Philwi , |
filipefurtad0
approved these changes
Aug 12, 2022
|
Hey @Philwi, Thanks for this improvement! 💪 After staging, it is possible to confirm the shop URL is clickable (
Merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #9427
On the admin dashboard, in "Enterprises" > "Primary details", the url pointing to the shop is not clickable. => Now the link is not only a text fragment but an a-tag with a target attribute to open the shop in an own tab.
What should we test?
Release notes
Changelog Category: User facing changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates