-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select all text upon focus on map search input for Google Maps #9204
Select all text upon focus on map search input for Google Maps #9204
Conversation
On the map page, when we search a location and than want to search for another, we would have to delete letter by letter of the previous search text. Now, when we click on the search input to type another search text, the previous text will be all selected and we can remove everything with just hitting the backspace once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this is an improvement but I think that it's not quite what was asked for.
You can select the input in the search field with the mouse (by selecting with the left mouse key pressed or double clicking to select the whole word) and then delete or overwrite the whole input in one step.
It says that you can select the text and not that it is already selected after on focus. @drummer83 Do you have an opinion on this?
What about supporting all 3 select modes? Wouldn't that be great 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about supporting all 3 select modes?
That would be cool. But I'll approve this as first step already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Thanks for reviewing and for the messages! |
Hi @diegoamc and thank you for this pull request! 💪 Before this pull request the input in the search field could only be deleted letter by letter: After this pull request the input is selected and can be deleted all at once: This is a great improvement! Thank you! 🥳 As discussed above there is still room for more improvement (which was not expected within this issue). I will open a new issue for that! This one is ready to go! 🕺 |
What? Why?
Closes #8755
On the map page, when we search a location and than want to search for
another, we would have to delete letter by letter of the previous search
text.
Now, when we click on the search input to type another search text, the
previous text will be all selected and we can remove everything with
just hitting the backspace once
What should we test?
Search input behavior on the map page using Google Maps. See gif below.
Release notes
Changelog Category: User facing changes