Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flatpickr from 4.6.9 to 4.6.11 #8992

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 14, 2022

Bumps flatpickr from 4.6.9 to 4.6.11.

Release notes

Sourced from flatpickr's releases.

v4.6.11

There was a bug with time selection since so much stuff got merged in. New tests have been added to prevent this from happening again.

What's Changed

New Contributors

Full Changelog: flatpickr/flatpickr@v4.6.10...v4.6.11

v4.6.10

What's Changed

... (truncated)

Commits
  • 2391b19 4.6.11
  • c2bc4f4 Merge branch 'master' of ssh://github.com/chmln/flatpickr
  • cd06580 Merge pull request #2650 from barszczmm/invalid-input-value-fix
  • da33a61 Merge pull request #2662 from mshibuya/fix-2653
  • ea09ebd Fix #2419 breaking with altInput and altFormat Enabled
  • 63e185e Bug fix: error thrown and calendar UI broken by invalid input value
  • b148b5d 4.6.10
  • 5b055df Fix npm vulnerabilities
  • 99c9bbf Merge pull request #2419 from Netatwork-de/topic/2394-blur-by-click
  • e8785b4 Merge pull request #2601 from mshibuya/fix/2541-breaking-with-alt-input
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [flatpickr](https://github.com/chmln/flatpickr) from 4.6.9 to 4.6.11.
- [Release notes](https://github.com/chmln/flatpickr/releases)
- [Commits](flatpickr/flatpickr@v4.6.9...v4.6.11)

---
updated-dependencies:
- dependency-name: flatpickr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies javascript Pull requests that update Javascript code labels Mar 14, 2022
Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be ok, but i think it deserves a little check by test team ;)

@jibees
Copy link
Contributor

jibees commented Mar 17, 2022

Testing notes

In the admin section, test the datepicker and the datetimepicker.

@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label Mar 17, 2022
@drummer83
Copy link
Contributor

Hi, here are my testing notes:

Pages where the datetime picker is being used:

  • /admin/order_cycles/835/edit# OPEN --> OK
  • /admin/order_cycles/835/edit# CLOSE --> OK
  • /admin/order_cycles/new OPEN --> OK
  • /admin/order_cycles/new CLOSE --> OK
  • /admin/order_cycles OPEN --> OK
  • /admin/order_cycles CLOSE --> OK
  • /admin/reports/orders_and_distributors START --> OK
  • /admin/reports/orders_and_distributors END --> OK
  • more reports --> OK

Pages where the date picker is being used:

  • /admin/subscriptions/3/edit BEGINS --> OK
  • /admin/subscriptions/3/edit ENDS --> OK
  • /admin/orders/bulk_management START --> OK
  • /admin/orders/bulk_management END --> OK
  • /admin/orders START --> OK
  • /admin/orders STOP --> OK

Users:

  • super admin
  • shop owner

Devices:

  • Desktop Firefox 98
  • Apple iPhone 12 Pro
  • Samsung Galaxy S20

Examples for user 'shop owner':

Datetime picker
Before:
before_datetime_ordercycle_new_end
After:
after_datetime_ordercycle_new_end

Date picker
Before:
before_date_orders_start
After:
after_date_orders_start

As far as I can tell everything seems to work as expected/before.

This is good to go! 🎈

@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Mar 17, 2022
@drummer83 drummer83 removed their assignment Mar 17, 2022
@filipefurtad0 filipefurtad0 merged commit f079fcb into master Mar 17, 2022
@filipefurtad0 filipefurtad0 deleted the dependabot/npm_and_yarn/flatpickr-4.6.11 branch March 17, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants