-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split checkout: Display "Update" button on the order table page unless order is complete #8944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No spec?
You're right, this needs some systems specs. |
With the split checkout, we can access this page between the different steps: for this cases, cart actions should be displayed
d180593
to
0fe1d6f
Compare
0fe1d6f
to
e14dad1
Compare
Already done by @filipefurtad0 : thanks! 🙏 Back in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hey @jibees , I think we need another look at this one. I've started the test with no issues: restricting the stock on /details and /payment steps redirected to /cart and displayed the "Details" button. After that, the checkout pages broke, for this shop (even after emptying the cart and starting over the checkout process) and for other shops too: The reason seems to be that the redirection is pointing to the Also, a bugsnag got triggered, during these tests. But I think for a different issue, here. |
I'll run some more tests around these scenarios in another server, as double check. Maybe it all relates to that UI issue, and this is good to merge 🤞 |
Thanks @filipefurtad0 |
Alright - other that #8963 which for some reason caused this persistent redirect to the I've checked both scenarios mentioned, can't think of anywhere else to check - I'd say we're good 👍 This closes the underlying issue - merging! 🎉 |
Split_checkout introduced new state for an order Update specs as well Follow up openfoodfoundation#8944
What? Why?
With the split checkout, we can access the
/cart
between the different steps: for this cases, cart actions should be displayed (and not only for thecart
state)Closes #8940
What should we test?
With split_checkout feature toggle activated:
on hand
0
/cart
page with an "Update" buttonWith legacy checkout:
on hand
0
/cart
page with an "Update" buttonThis modification comes from an issue around the split checkout, but could impact the legacy checkout system: ie. the code is shared between split/legacy checkout.
I've tested this page for both split and legacy checkout and I didn't find any issue, but maybe I've missed some place where this page/table is used.
Release notes
Changelog Category: User facing changes
The title of the pull request will be included in the release notes.