Fix product import on existing, empty unit_type and variant_unit

[SarvarKh]

What? Why?

Closes #8773

Importing product file with empty unit_type andvariant_unit_name columns on already existing products was failing without any error notice to the user.

What should we test?

• Visit /admin/product_import page.
• Fill out product list template (.csv) leaving unit_type andvariant_unit_name columns empty and product name column to already existing product name.
• Select your .csv file, upload and import.

Corresponding error notification appears.

Release notes

Changelog Category: User facing changes

[mkllnk]

Great!

Would you like to write a spec, too? You could improve spec/models/product_import/entry_validator_spec.rb.

[SarvarKh]

Thank you @mkllnk
I noticed only the inventory validation spec was tested.
To test product validation, I have been trying to mock tax_and_shipping_validation for validate_all without success so far.

In short, its arguments are throwing an error:

  1) ProductImport::EntryValidator product validation products exist validates a spreadsheet entry in kg
     Failure/Error: tax_and_shipping_validation(entry, 'tax', entry.tax_category, @spreadsheet_data.tax_index)
       #<Double :spreadsheet_data> received unexpected message :tax_index with (no args)

Tried to do something like:

allow(entry_validator).to receive(:tax_and_shipping_validation).with(entry_product, true, entry_product.tax_category, true).and_return({something: 'testing'})

[mkllnk]

It's not a great spec. It uses a lot of mocked data. But I created an example to show how you can reach the code you fixed:

+  describe "variant validation" do
+    let(:potatoes) {
+      create(
+        :simple_product,
+        supplier: enterprise,
+        on_hand: '100',
+        name: 'Potatoes',
+        unit_value: 1000,
+        variant_unit_scale: 1000,
+        variant_unit: 'weight'
+      )
+    }
+    let(:potato_variant) do
+      ProductImport::SpreadsheetEntry.new(
+        unscaled_units: "1",
+        units: "1",
+        unit_type: "kg",
+        name: potatoes.name,
+        display_name: 'Pink Potatoes',
+        enterprise: enterprise,
+        enterprise_id: enterprise.id,
+        producer: enterprise,
+        producer_id: enterprise.id,
+      )
+    end
+
+    before do
+      allow(import_settings).to receive(:dig)
+      allow(spreadsheet_data).to receive(:tax_index)
+      allow(spreadsheet_data).to receive(:shipping_index)
+      allow(entry_validator).to receive(:enterprise_validation)
+      allow(entry_validator).to receive(:tax_and_shipping_validation)
+      allow(entry_validator).to receive(:variant_of_product_validation)
+    end
+
+    it "validates a product" do
+
+      entries = [potato_variant]
+      entry_validator.validate_all(entries)
+
+      expect(potato_variant.errors.count).to eq 0
+    end
+  end

There are still errors on the entry. This is not a complete test case but maybe a start for you?

[SarvarKh]

The given example was a great help, thanks.

[jibees]

👌 🙏

[filipefurtad0]

Hey @SarvarKh ,

I could reproduce the error on the freezing progress bar, it seems the same as the one reported here:
#5363 (comment)

After your PR this is fixed:

The user sees why the file is not uploaded, and the error is not seen on the Response tab:

Updating other fields like stock, but having unit_type = g (in this case) works as before 👍

So, this closes both #5363 and #8773 - awesome!!! 💪 🚀