[Split Checkout] Adds tests on payments #8772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This draft PR is failing with: This is reproducible in staging:
|
filipefurtad0
changed the title
filipefurtad0
force-pushed
the
add_specs_split_checkout_payment
branch
from
bddb642 to
c550408
Compare
filipefurtad0
force-pushed
the
add_specs_split_checkout_payment
branch
4 times, most recently
from
e8e5cca to
82809a5
Compare
filipefurtad0
force-pushed
the
add_specs_split_checkout_payment
branch
from
82809a5 to
e267ae4
Compare
filipefurtad0
force-pushed
the
add_specs_split_checkout_payment
branch
from
e267ae4 to
d945e69
Compare
mkllnk
reviewed
Feb 25, 2022
Comment on lines
298
to
299
| let!(:payment_method3) { create(:payment_method, distributors: [distributor], name: "Cash") } | ||
| let!(:payment_method4) { create(:payment_method, distributors: [distributor], name: "BoGuS") } |
There was a problem hiding this comment.
I would name these cash and bogus instead of payment_method3 and payment_method4.
There was a problem hiding this comment.
Thanks @mkllnk 🙏
On the payment method re-namings:
- I've renamed
payment_method3tocash payment_method4was actually a detour, it got removed on the following commit - sorry if this was a bit misleading.
filipefurtad0
force-pushed
the
add_specs_split_checkout_payment
branch
from
ac4516c to
82b6d39
Compare
mkllnk
approved these changes
Feb 28, 2022
jibees
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Contributes to #8667 by adding coverage on payment method selection.
These can perhaps be extended in other dedicated spec files, for example on:
spec/system/consumer/shopping/checkout_paypal_spec.rbspec/system/consumer/shopping/checkout_stripe_spec.rbWhat should we test?
Green build.
Release notes
Changelog Category: Technical changes
Adds tests on payment methods for split checkout.