Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flaky system spec reliable #8605

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Make flaky system spec reliable #8605

merged 1 commit into from
Dec 10, 2021

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Dec 10, 2021

What? Why?

Closes #8449

It was failing 50% of the time since it was converted into a system spec. The input selection was going too fast and we were still waiting for an API call to set the state values (depending on the country) while the state Victoria was selected.

What should we test?

Green build.

Release notes

Changelog Category: Technical changes

It was failing 50% of the time since it was converted into a system
spec.
@mkllnk mkllnk requested a review from filipefurtad0 December 10, 2021 03:07
@mkllnk mkllnk self-assigned this Dec 10, 2021
@filipefurtad0 filipefurtad0 merged commit 215d8fc into openfoodfoundation:master Dec 10, 2021
@mkllnk mkllnk deleted the 8449-flaky-spec branch January 20, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flaky spec] /system/admin/order_spec.rb:192
3 participants