Update Rubocop config #8570
Merged
Update Rubocop config #8570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
The assignments here didn't actually do anything and `number` was restricted to numbers only already. No whitespace to remove.
Rubocop highlighted this. The todo list actually contains these files but somehow the cop still runs and reports these as violations.
We used to keep a manual file for metrics violations because the automatic file didn't exclude on a file-by-file basis. But Rubocop has an additional option these days so that we can generate that automatically in the normal todo list. The todo list was also out of date.
|
The longer we wait the more this PR is out of sync with master and I have to rebase it again and again. So I just did that and I'll merge it now. It may need a follow up once all other current PRs have been merged (if they introduce new violations or move files). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Our new Rubocop check in Github Actions fails pull requests which didn't introduce any style violations. The regeneration of the todo list should let everything pass so that we only observe regressions from now on.
What should we test?
Nothing.
Release notes
Changelog Category: Technical changes
Dependencies
None but this should be merged ASAP before other style violations are introduced in master again.