Moves/updates subscriptions_spec into system #8462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipefurtad0
force-pushed
the
admin_into_features_iv
branch
from
d11d785 to
fa4a2db
Compare
Matt-Yorkley
reviewed
Nov 8, 2021
| @@ -187,7 +187,7 @@ | |||
| select2_select 'VISIBLE', | |||
| from: "enterprise_tag_rules_attributes_4_preferred_matched_shipping_methods_visibility" | |||
| end | |||
|
|
|||
| =begin | |||
There was a problem hiding this comment.
Was this meant to be left in?
There was a problem hiding this comment.
I'm not sure. I've opted to keep the drag_to related assertions commented out till we find a solution for issue #8463
But maybe this is missing a comment line to explain the context. What do you think?
There was a problem hiding this comment.
Ah I see! Okay, lets go with this for now 👍
Matt-Yorkley
approved these changes
Nov 8, 2021
jibees
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Continues #8103
Moves several admin specs into system specs.
What should we test?
Green build.
Release notes
Moves several admin specs into system specs.
Changelog Category: Technical changes