Fix debounce on variant search dropdown

[Matt-Yorkley]

What? Why?

This wasn't applied correctly so there was zero debounce, leading to a big excess of pointless requests whilst typing in the variant search dropdown.

What should we test?

If you try the "add variants" dropdown in the new subscription page it should be obvious that each letter typed in the box triggers a new request (check the network tab). After this, there should be a short delay, and only the last value will be sent in a single request (after half a second).

Release notes

Fixed debounce on variant search dropdowns

Changelog Category: Technical changes

[mkllnk]

Is this something we could test for? Like sending five keys in and expect that only one request has been made after 600 ms.

[Matt-Yorkley]

Is this something we could test for? Like sending five keys in and expect that only one request has been made after 600 ms.

It might be tricky with Capybara. I could have a go, but it's much easier to test it manually. I'd like to get this one in the release as the effects are really problematic in some cases (large hubs with lots of variants and overrides).

[filipefurtad0]

Hey @Matt-Yorkley ,

Awesome 👀

Indeed huge difference in what the request numbers is concerned 👍

Below (left) a staging server without this PR and on the right the staging server after staging:

The string above is not representative in what existing variants is concerned, but this was tested as well and all works as before.

500 ms seems just about the right value not to compromise usability/responsiveness. This looks perfect 🚀