If an order has out of stock line items display them and let admins remove them #8438
Conversation
cillian
force-pushed
the
show-out-of-stock-line-items
branch
from
098601b to
d2aa7c6
Compare
|
@mkllnk no problem. I think this is okay now, I rebased with the latest |
There was a problem hiding this comment.
Alright... so as a bit of background to the underlying issue; the cart page has a certain bit of logic that uses line items with zero quantity as a kind of "placeholder" to allow the customer to see when an item in their cart has gone out of stock whilst shopping. You can't tell the customer which item is out of stock unless you keep a record in the database of that item. Makes sense. The problem with that is that the rest of the app code is not designed with that implementation in mind; the idea that a line item with zero quantity can even exist is basically a total anomaly from the point of view of the backoffice code, for example. That's where this inconsistency comes from, there's certain cases where these zero-quantity items can be created but the order edit page doesn't recognise them.
I think the approach you've gone for is good, it's definitely moving things in the right direction 👍👍 There's a little bit more complexity here that needs looking at though.
So... these zero-quantity items should only really exist in orders in an incomplete state, and they should only really be temporary. When a line item is in the cart but the order is not completed, the item hasn't actually been sold yet and the stock has not been reduced. An order can't be completed with a zero-quantity line item (because they can't be sold). Also; after an order is completed the items actually are sold, and the stock is reduced. At this point the sale has been done, and for example one of those line items in the order could very well be pointing to a product which has subsequently gone out of stock (imagine an order is placed for the last bag of carrots, after the order is completed there are no carrots left).
If you edit a completed order (with this PR) and some of the items are out of stock, it will show the "out of stock" feedback in big red letters, which is not actually correct in that context. So I think what we need to do is only apply that check (if @order.insufficient_stock_lines.any?) and the partial that shows the "out of stock" items when the order is not yet complete.
Does that make sense?
Whew, I had to burn a few neurons there putting all that into words 😅
| @@ -2,6 +2,9 @@ | |||
| - if @line_item.try(:errors).present? | |||
| = render :partial => 'spree/shared/error_messages', :locals => { :target => @line_item } | |||
|
|
|||
| - if @order.insufficient_stock_lines.any? | |||
There was a problem hiding this comment.
TLDR version:
| - if @order.insufficient_stock_lines.any? | |
| - if [email protected]? && @order.insufficient_stock_lines.any? |
I think that'll be sufficient ☝️
We might want a little bit more in terms of test coverage though..?
cillian
force-pushed
the
show-out-of-stock-line-items
branch
4 times, most recently
from
86f9160 to
ca00f4e
Compare
|
@Matt-Yorkley Thanks for the detailed explanation 😅, good to know. I have made that adjustment now, added view specs and rebased. |
Matt-Yorkley
force-pushed
the
show-out-of-stock-line-items
branch
from
ca00f4e to
e2b8108
Compare
|
Note: I rebased on master and tweaked some of the CSS bits, as we've recently changed how our CSS assets are bundled 👌 |
|
Hey @cillian , Before this PR:
After this PR:
Awesome!! 🎉 |
What? Why?
For #8178. Before only customers could delete out of stock line items and out of stock line items would not be displayed when an order was viewed in the admin area. This changes things so the out of stock line items are displayed in the admin area and gives the admin the ability to delete them.
What should we test?
Release notes
If an order has out of stock line items display them and let admins remove them.
Changelog Category: User facing changes