Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin enterprise specs into system #8431

Merged

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Oct 29, 2021

What? Why?

Continues #7299

Updates/moves several admin/enterprise feature specs into system.

What should we test?

Green build.

Release notes

Updates/moves several admin/enterprise feature specs into system.

Changelog Category: Technical changes

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 marked this pull request as draft October 29, 2021 10:44
@sigmundpetersen
Copy link
Contributor

sigmundpetersen commented Oct 29, 2021

Hey @filipefurtad0
Should we split up the spec/system job as it was done with the spec/feature job?
The build time is increasing now when building all system specs in 1 job

Maybe not in this PR though 🙂
👍

@filipefurtad0
Copy link
Contributor Author

That's a great idea @sigmundpetersen , thank you :-)

@Matt-Yorkley
Copy link
Contributor

Should we split up the spec/system job as it was done with the spec/feature job?

Ah I just did that here: #8432 👍

@filipefurtad0 filipefurtad0 force-pushed the admin_specs_into_system branch from 6ddba7c to cb753bb Compare October 29, 2021 12:00
@filipefurtad0 filipefurtad0 changed the title Admin specs into system Admin enterprise specs into system Oct 29, 2021
@filipefurtad0 filipefurtad0 marked this pull request as ready for review October 29, 2021 12:04
@filipefurtad0 filipefurtad0 force-pushed the admin_specs_into_system branch from cb753bb to a1b094b Compare October 29, 2021 13:28
@Matt-Yorkley Matt-Yorkley merged commit b0545c7 into openfoodfoundation:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants