Translate stripe error messages during payment processing #8405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibees
changed the title
Matt-Yorkley
approved these changes
Oct 29, 2021
jibees
force-pushed
the
7961-translate-stripe-error-message
branch
from
d4d2379 to
99e9660
Compare
mkllnk
requested changes
Nov 11, 2021
- Stripe error messages aren't translated. But, Stripe send the error code. Use it (if found it, and translation key does exist) to translated the error message - Populate the en.yml file with some of the most known errors Co-Authored-By: Matt-Yorkley <[email protected]>
jibees
force-pushed
the
7961-translate-stripe-error-message
branch
from
99e9660 to
7041ec7
Compare
mkllnk
approved these changes
Nov 15, 2021
|
Hey @jibees , To stage this PR it was proceeded as follows:
As an example, here is the error message for This works 🎉 I've found there are still some cases which are not covered by the added keys, like
Or in the UI itself: But these can be addressed in separate PRs 👍 Good to go. |
|
wow now I understand why users are unable to tell us what went wrong with their payments! If they see messages like for insufficient funds in English... 🤦 |
|
Thanks @filipefurtad0 : feel free to open two separates issues for those two cases, they aren't the same I guess, but I'd be happy to tackle them ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #7961
Stripe error messages aren't translated.
But, Stripe send us an error code: use it (if found it and translation key does exist) to translated the error message
Populate the en.yml file with some of the most known errors
What should we test?
Test that stripe error messages (with different card number: https://stripe.com/docs/testing#cards-responses):
Release notes
Add translation for Stripe errors
Changelog Category: User facing changes