Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken layout of bulk buy #8366

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fix broken layout of bulk buy #8366

merged 1 commit into from
Oct 28, 2021

Conversation

lamphanqg
Copy link

What? Why?

Closes #7230

What should we test?

Bulk buy feature

  1. Add an item which has "bulk buy" enabled to the cart by clicking "add".
  2. Look at the modal for choosing "Min quantity" and "Max quantity".

Screenshots

Capture

mkllnk
mkllnk approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jibees
jibees approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@filipefurtad0 filipefurtad0 self-assigned this Oct 28, 2021
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Oct 28, 2021
@filipefurtad0
Copy link
Contributor

Hey @lamphanqg ,
Welcome 🎉

The issue seems to observable not only in Windows/Firefox (1) but also on some other combinations, like Ubuntu/Chrome (2).

After staging this PR, the issue is fixed, as seen below (left, (1); right (2):

image

Also checked some mobile devices/browsers like - in which no change is introduced by this PR:

  • iPhone v14.2 / Safari

image

  • Android, v11.0 / Chrome / Firefox

image

All good.

Thanks for this!
Ready to go.

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Oct 28, 2021
@Matt-Yorkley Matt-Yorkley merged commit f0ec739 into openfoodfoundation:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkllnk mkllnk mkllnk approved these changes

@jibees jibees jibees approved these changes

Assignees

@filipefurtad0 filipefurtad0

@lamphanqg lamphanqg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken layout of bulk buy feature
5 participants
@lamphanqg @filipefurtad0 @jibees @mkllnk @Matt-Yorkley