Enterprises into system

[filipefurtad0]

What? Why?

Relates to #8103

Updates and moves features/admin/enterprises files into system/admin/enterprises

What should we test?

Green build.

Release notes

Updates and moves features/admin/enterprises files into system/admin/enterprises

Changelog Category: Technical changes

[filipefurtad0]

No idea what's happening here :-/ all these specs pass locally, after these these changes 🤯

[mkllnk]

Seems order dependent. I'm currently running this:

rspec --seed 0 --bisect spec/system/admin/customers_spec.rb spec/system/admin/enterprises/business_address_form_spec.rb spec/system/admin/enterprises/index_spec.rb

[mkllnk]

Bisect didn't really help much but I found a minimal failing combination manually:

rspec \
./spec/system/admin/customers_spec.rb[1:1:1:1] \
./spec/system/admin/enterprises/business_address_form_spec.rb[1:1:1:1] \
./spec/system/admin/enterprises/index_spec.rb[1:1:1]

They are all needed. And then we get this:

Somehow the user session may not be reset properly? I'm trying to figure that out.

[mkllnk]

I found it! business_address_form_spec still required the spec_helper instead of the system_helper. So if you first loaded a spec with the system helper, then the spec_helper, then specs after that would fail.

[filipefurtad0]

Thank you for your work on this @mkllnk, I seem to have missed that file.

I ran the bisect command you've posted but got no results whatsoever (it just ran endlessly). This was probably caused by loading the wrong helpers as well.

[filipefurtad0]

Ohh f..! 💥

I seem to have removed @mkllnk 's commit accidentally... Sorry, about that Maikel... Learning in progress... I guess that's what git reset --hard does 🤣 I've re-set now the correct helper on business_address_form_spec.rb
Again, sorry 🙌

[mkllnk]

Looks great!