Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move embedded_shopfronts_spec as system spec #8336

Conversation

jibees
Copy link
Contributor

@jibees jibees commented Oct 12, 2021

What? Why?

Closes #8335

What should we test?

Green build.

Release notes

Move flaky embedded_shopfronts_spec as system spec

Changelog Category: Technical changes

@jibees jibees force-pushed the 8335-fix-flaky-embedded_shopfronts_spec branch from 62350c2 to 059163c Compare October 12, 2021 12:29
Copy link
Contributor

@filipefurtad0 filipefurtad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here: no conflicts, green build, uncontroversial change: approving and merging.
Thanks JB! One spec less to update to system 💪

@filipefurtad0 filipefurtad0 merged commit 8aa7ef2 into openfoodfoundation:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky] spec/features/consumer/shopping/embedded_shopfronts_spec.rb:54
2 participants