Fix flaky checkout auth spec #8318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibees
approved these changes
Oct 8, 2021
| @@ -620,7 +620,7 @@ def shows_products_without_customer_warning | |||
| def expect_out_of_stock_behavior | |||
| # Shows an "out of stock" modal, with helpful user feedback | |||
| within(".out-of-stock-modal") do | |||
| expect(page).to have_content I18n.t('js.out_of_stock.out_of_stock_text') | |||
| expect(page).to have_content I18n.t('js.out_of_stock.out_of_stock_text').strip | |||
There was a problem hiding this comment.
I did the same modification here:
3d87485#diff-5c1d6c796b83b24b53a26a2ade65fc6db38bbcb755d1cf4babe613b5718d2843R623 :)
There was a problem hiding this comment.
Hum, sorry seems I have mixed up files?! I actually wanted to address a checkout_auth_spec.rb file - my mistake. I'll nuke these commits to work start over 👍
filipefurtad0
force-pushed
the
fix_flaky_checkout_auth_spec
branch
from
74d7b0b to
8640404
Compare
|
Ok, updated with the correct file 👍 sorry for the mix-up! 🤯 |
|
Already approved then ;) |
|
I guess updating it into system is not really changing much in terms of flakyness :-) rspec ./spec/system/consumer/shopping/checkout_auth_spec.rb:49 # As a consumer I want to check out my cart using the checkout populates user details once logged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #8281
Updates this feature spec into system spec, as a first approach to mitigate flakyness.
What should we test?
Green build.
Release notes
Updates /consumer/shopping/shopping_spec.rb into system spec.
Changelog Category: Technical changes