Orders spec update #8264
Merged
Orders spec update #8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
approved these changes
Oct 5, 2021
spec/system/admin/orders_spec.rb
Outdated
| @@ -179,6 +186,7 @@ | |||
| fill_in "Email", with: user.email | |||
| fill_in "First name begins with", with: "J" | |||
| fill_in "Last name begins with", with: "D" | |||
| byebug | |||
There was a problem hiding this comment.
You can remove this from the Git history before submitting a PR. The easiest way I find is to make a single commit that just removes the line, then do an interactive rebase and put the fixup commit directly under the commit with the mistake and mark it as "fixup". The two commits then get merged into one and it's like this line never happened. 😄
Comment on lines
+81
to
+86
| it "filter by complete date" do | ||
|
|
||
| login_as_admin_and_visit 'admin/orders' | ||
|
|
||
|
|
||
| find('#q_completed_at_gteq').click |
andrewpbrett
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Relates to #8216 (won't close it just yet)
Adds test cases to the
/orderspage.What should we test?
Green build.
Release notes
Improves test coverage on the orders page (release test automation).
Changelog Category: Technical changes
Documentation updates
Manual release testing document should be updated after merging this PR.