Fix display of "inventory only" radio buttons

[Matt-Yorkley]

What? Why?

Addresses UI issue described in #8256 (comment)

Previously the two radio buttons were not showing which option was set; both options were blank even if one had been selected.

What should we test?

When an inventory setting is set in the enterprise "Inventory Settings" tab, it should correctly show which setting is currently in use. Note: the default value is false.

Release notes

Fixed display of "inventory only" setting in enterprise edit page

Changelog Category: Technical changes

[mkllnk]

And simplifying the code. 😍

[filipefurtad0]

Hey @Matt-Yorkley ,

I've checked this now, for

• pre-existing enterprises
  It can be seen that where previously no selection in the UI was visible, i) now there is one, and ii) that it corresponds to the value in the DB. Changing it and updating the values changes the values in the DB accordingly:

• newly created enterprises

As before, the default selection is seen in the UI, but I cannot seem to find this preference saved in the DB:

Would it be expected that there is a preference entry on the DB? Or is this only expected if it differs from the false default setting? I'm thinking we might still have bug occurrences if this is missing, but I'm not sure. What do you think?

PS: Even though the DB does not show this preference, I could not reproduce the bug here - it is possible to add products on the outgoing section:

So maybe we're good? Will await for your feedback on this.

[filipefurtad0]

I've moved it to ready to go - there's a good chance this fixes the S1 👍 We can consider this one perhaps a prod-test, as I was not able to reproduce the exact scenario in staging.

[Matt-Yorkley]

Would it be expected that there is a preference entry on the DB? Or is this only expected if it differs from the false default setting?

Yes, that's how it generally works with defaults 👌

[filipefurtad0]

Ah great! I was unaware of that, thank you for that feedback 👍