Simplify GH Actions config with matrix syntax #8253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibees
approved these changes
Oct 18, 2021
This demonstrates how you can split the tests across multiple jobs without repeating the job configuration. This has a lot of potential to DRY our config.
This uses the matrix syntax for all rspec calls. It is easier to maintain than the previous list of GH Actions workflows. The execution of the rspec rake task is still in its own job because it doesn't fit in the same pattern. The JS tests are also executed in that job.
It's already defined globally.
It's nice to see the whole result to then work on all failures, especially when there are flaky specs.
|
Thank you, just rebasing to make sure all tests are still good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Our config is very repetitive. Let's try to DRY it so that it's easier to maintain.
Initially, I wanted to use Knapsack which does a much better job at balancing. But system specs have to run separately at the moment and there's no easy way to exclude spec files from loading when using Knapsack (you can exclude them from execution, but not loading). So I kept the current directory lists.
What should we test?
Specs have to pass.
Release notes
Changelog Category: Technical changes
Simplified config for Github Actions.