Fix payment method fee bug for all calculator types #8204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only tested these changes on cash and paypal payment methods, but this will probably take care of stripe as well. I tried to test it on a stripe payment method, but only paypal express and cash were available as providers in the form. |
meronogbai
changed the title
andrewpbrett
approved these changes
Sep 24, 2021
|
Hey @meronokbay , Thanks for fixing this! I've checked:
payment methods in combination with the available calculators:
All good! The warning is displayed in all cases. Moving to ready to go! PS: I thought I'd check what happens regarding shipping methods and enterprise fees, since these use the same calculators, and it seems we have the same issue, which was pre-existing, of course - I've opened this issue and this one, respectivelly. |
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Related to #6942
Related to #8144
This will take care of validating the payment fee input for paypal and cash payment methods and all calculators.
What should we test?
Input a non-number value in the fields of a payment method edit form and try to click on update. You should see a flash error message instead of a 500 error.
Release notes
Validate payment method fee input for all calculator types
Changelog Category: User facing changes