-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpickr only use language and not locale #7972
Flatpickr only use language and not locale #7972
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7972 +/- ##
===========================================
- Coverage 93.27% 23.13% -70.14%
===========================================
Files 640 568 -72
Lines 18152 20869 +2717
===========================================
- Hits 16931 4829 -12102
- Misses 1221 16040 +14819
Continue to review full report at Codecov.
|
- if "fr": return "fr" - if "fr_FR": return "fr"
88a378e
to
f39cc49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Hey @jibees , Before - console errors; translation on the date-time-picker is broken (for After - no console errors; translation on the date-picker is working! Checked the following pages:
Also staged and tested in servers in which the locale is
Awesome - ready to go 🎉 |
What? Why?
Flatpickr can be configured by passing a locale but it's more only a language than a locale.
Create and use a small attribute onto
I18n
javascript object.Closes #7928
What should we test?
fr_CA
admin/orders/bulk_management
fr
languageRelease notes
Use the right language for date(time)picker when configured locale contains also country
Changelog Category: User facing changes