Fixed Bug on payment transalation state

[vishaldeepak]

What? Why?

Fixes bug #7681. The scope being used was incorrect.

Closes #7681

What should we test?

Try opening invoice or an email.

Release notes

Fixed a bug where translation was not being made for payment states on a invoice

Changelog Category: User facing changes

[vishaldeepak]

On a side note we may want to translate the Payment methods as well? Example being Cash on Collection on the above image

[andrewpbrett]

This looks great, thanks @vishaldeepak! One small note is that in the PR description I'd call this a User Facing Change and not a technical change.

Normally we need two approvals before marking something as Test Ready but this is straightforward so I'm going to move in there with just one.

[codecov]

Codecov Report

Merging #7915 (9dae0d5) into master (718f9c4) will decrease coverage by 78.01%.
The diff coverage is n/a.

❗ Current head 9dae0d5 differs from pull request most recent head 6918538. Consider uploading reports for the commit 6918538 to get more accurate results

@@             Coverage Diff             @@
##           master    #7915       +/-   ##
===========================================
- Coverage   93.27%   15.26%   -78.02%     
===========================================
  Files         638      568       -70     
  Lines       18144    22845     +4701     
===========================================
- Hits        16924     3487    -13437     
- Misses       1220    19358    +18138     

Impacted Files	Coverage Δ
app/jobs/job_logger.rb	0.00% <0.00%> (-100.00%)	⬇️
app/jobs/heartbeat_job.rb	0.00% <0.00%> (-100.00%)	⬇️
app/models/exchange_fee.rb	0.00% <0.00%> (-100.00%)	⬇️
app/services/unit_price.rb	0.00% <0.00%> (-100.00%)	⬇️
app/models/order_balance.rb	0.00% <0.00%> (-100.00%)	⬇️
app/helpers/mailer_helper.rb	0.00% <0.00%> (-100.00%)	⬇️
app/jobs/bulk_invoice_job.rb	0.00% <0.00%> (-100.00%)	⬇️
app/models/stripe_account.rb	0.00% <0.00%> (-100.00%)	⬇️
app/services/cap_quantity.rb	0.00% <0.00%> (-100.00%)	⬇️
app/services/cart_service.rb	0.00% <0.00%> (-100.00%)	⬇️
... and 579 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718f9c4...6918538. Read the comment docs.

[filipefurtad0]

Hey @vishaldeepak ,

Before your PR:

After your PR:

Awesome, thanks for your contribution!
Good to go 👍

[drummer83]

On a side note we may want to translate the Payment methods as well? Example being Cash on Collection on the above image

@vishaldeepak Can you double check that some payment methods are really not translated? In German at least some of them actually are translated...