Delete dead code in OrdersController#update_distribution

[Matt-Yorkley]

What? Why?

I can't see any evidence that these params ever get sent to this action containing these strings.

Correct me if I'm wrong though!

🔥🔥

What should we test?

This theoretically relates to places in the frontoffice where the user can select either the distributor or the order cycle for their current order. There's not many places where we do that. I guess just a quick check that the user can choose a shop and select an order cycle? Are there any other places or scenarios where that could theoretically happen?

Release notes

Removed some unused code from OrdersController.

Changelog Category: Technical changes

[codecov]

Codecov Report

Merging #7638 (eafd74f) into master (4932e1d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head eafd74f differs from pull request most recent head 82a6bef. Consider uploading reports for the commit 82a6bef to get more accurate results

@@            Coverage Diff             @@
##           master    #7638      +/-   ##
==========================================
+ Coverage   93.21%   93.26%   +0.05%     
==========================================
  Files         635      635              
  Lines       18136    18129       -7     
==========================================
+ Hits        16905    16908       +3     
+ Misses       1231     1221      -10     

Impacted Files	Coverage Δ
app/controllers/api/v0/shipments_controller.rb	100.00% <100.00%> (+2.85%)	⬆️
app/controllers/spree/orders_controller.rb	92.59% <100.00%> (+6.03%)	⬆️
...ent/app/services/order_management/order/updater.rb	98.73% <100.00%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4932e1d...82a6bef. Read the comment docs.

[luisramos0]

nice! I'd say this is a pr-no-test.

[luisramos0]

can you move these before_actions, only: update to beginning of the update method?

[sauloperez]

👏

[sauloperez]

I guess just a quick check that the user can choose a shop and select an order cycle? Are there any other places or scenarios where that could theoretically happen?

this is definitely covered by the test suite. Are you happy to merge this @Matt-Yorkley I'm with @luisramos0 on the pr-no-test.

[Matt-Yorkley]

Moving those before_action methods into the action broke various specs 😞 I've dropped that commit for now.

I think this controller needs more cleanup at some point, but maybe in another PR. For example, I'm not sure that params-mangling that's happening in #filter_order_params actually works in the way it was originally intended to (since Rails 4.2)!

[luisramos0]

👍 🙈