Ransack.search is deprecated. Use .ransack instead

[viktorsmari]

What? Why?

We are still using the soon to be deprecated Ransack's .search method. We should be using ransack instead.

When running tests on master we get this warning:

DEPRECATION WARNING: #search is deprecated and will be removed in 2.3, please use #ransack instead

Also, this dependabot PR was merged a few days ago (Bump ransack from 2.3.0 to 2.4.1):
#7545

Ransack's official PR:
activerecord-hackery/ransack#975

[codecov]

Codecov Report

Merging #7590 (6a342ae) into master (5a16954) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7590   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         635      635           
  Lines       18136    18136           
=======================================
  Hits        16903    16903           
  Misses       1233     1233           

Impacted Files	Coverage Δ
app/services/permissions/order.rb	100.00% <100.00%> (ø)
.../open_food_network/order_and_distributor_report.rb	93.33% <100.00%> (ø)
...open_food_network/order_cycle_management_report.rb	100.00% <100.00%> (ø)
lib/open_food_network/payments_report.rb	78.20% <100.00%> (ø)
lib/open_food_network/reports/line_items.rb	96.29% <100.00%> (ø)
lib/open_food_network/xero_invoices_report.rb	97.89% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a16954...6a342ae. Read the comment docs.

[Matt-Yorkley]

Nice, I've been meaning to do this for a while.

Thanks!

[andrewpbrett]

I'd say we're covered by the build in this case, what do you think @Matt-Yorkley?