Update things related to some package manager influencing setup process

[psychoslave]

What? Why?

Fixes #7521

The version specified in the .node-version file is no longer supported, and trying to install it through nodenv or the like will not allow to run the project on a bright new system.

This patch:

• set node version to the last LST 14.16.1
• follows the recommendations of @Matt-Yorkley to remove the node test in ./script/setup.
• replaces npm with yarn
• remove everything related to newrelic

What should we test?

Anything that allows to make sure no dependencies require a version

Release notes

Fix hindrances on new setup related to Node version

Changelog Category: Technical changes

Dependencies

Documentation updates

Already done:

• https://github.com/openfoodfoundation/openfoodnetwork/wiki/Development-Environment-Setup:-Ubuntu

Possibly might also require some edits:

• https://github.com/openfoodfoundation/openfoodnetwork/wiki/Development-Environment-Setup%3A-Debian
• https://github.com/openfoodfoundation/openfoodnetwork/wiki/Development-Environment-Setup%3A-Fedora
• https://github.com/openfoodfoundation/openfoodnetwork/wiki/Development-Environment-Setup%3A-OS-X

[psychoslave]

Github specific shortcut syntax to issues still seem to be a mystery for me 😆

[codecov]

Codecov Report

Merging #7578 (a4d6e69) into master (5a16954) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7578   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         635      635           
  Lines       18136    18136           
=======================================
  Hits        16903    16903           
  Misses       1233     1233           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a16954...a4d6e69. Read the comment docs.

[viktorsmari]

@psychoslave are you using nodenv or another tool like nvm?
I was thinking if https://github.com/nvm-sh/nvm has become the standard with its .nvmrc file.

Last update to the nodenv repo was July 2020 and it has 1.5k stars
Last update to the nvm repo 5 days ago and it has 48k stars

We might also be able to symlink these files, but I thought the .nvmrc file was the 'unofficial' winner 😸

[psychoslave]

Hello @viktorsmari

I did installed nodenv as it was recommended in the documentation for dealing with dependencies on Ubuntu. That said @Matt-Yorkley reported that using the official Ubuntu Node package is enough.

The project currently doesn't have a .nvmrc, but it can be added, this is all up to the community. For a matter of simplicity, I would recommend to avoid to add multiple concurrent solution in the repository. Maybe nodenv was retained because its sub-commands are aligned with rbenv which is also highlighted in the documentation.

If some consensus arise in OFN community that it would be great to move to nvm as a recommanded tool, then I would suggest to remove references to nodenv in the main path of the documentation and push that instead.

In any case, it's always possible to add specific documentation in a peripheral wiki page/section explaining how to set up a symlink that won't be tracked by git so no one is bothered with all possible preferences.

Anyway, as interesting as the topic might be, I think it should be treated in its own issue and pull request. This one doesn't intend to address something that it is not directly pertaining to the #7578.

[viktorsmari]

I agree, fewer files are better and symlinking might be an overcomplication 😄

Since this PR is removing the only reference to nodenv in the repo, maybe the .node-version file is not needed at all, what does @jibees say, do you use any particular Node version manager?

This could be part of another PR / discussion, I just thought it was related.

We could also remove references to nodenv in the wiki, I found them in 2 places:

• https://github.com/openfoodfoundation/openfoodnetwork/wiki/Development-Environment-Setup%3A-Ubuntu#step-4-installing-node
• https://github.com/openfoodfoundation/openfoodnetwork/wiki/Development-Environment-Setup%3A-Fedora#install-node-using-nodenv

Maybe detailing in the wiki how each version manager is installed on multiple operating systems should not be the responsibility of OFN? These things change and every time I personally install rbenv, I would rather follow the official documentation of rbenv.

Maybe it would be enough if we link to the official docs of each package manager, instead of copy pasting their installation instructions. Just a thought 😃

[Matt-Yorkley]

Thanks!

[andrewpbrett]

Github specific shortcut syntax to issues still seem to be a mystery for me 😆

I fixed that, I think the problem was you had the extra [ and ] around the issue number. You just need #1234, for example.