Add test coverage to BulkLineItemsController actions #7576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spec includes taxes on line items, fees on the order and on line items, taxes on fees (inherited and non-inherited), shipping and payment fees and taxes on shipping. It checks all of these things are correctly updated after the order is changed via BOM.
Matt-Yorkley
commented
May 7, 2021
| expect(order.total).to eq 61.0 | ||
| expect(order.item_total).to eq 40.0 | ||
| expect(order.adjustment_total).to eq 21.0 | ||
| expect(order.included_tax_total).to eq 2.65 # Pending: this should be 3.10! |
There was a problem hiding this comment.
This is fixed in #7429
Codecov Report
@@ Coverage Diff @@
## master #7576 +/- ##
==========================================
+ Coverage 93.18% 93.20% +0.01%
==========================================
Files 635 635
Lines 18130 18136 +6
==========================================
+ Hits 16895 16904 +9
+ Misses 1235 1232 -3
Continue to review full report at Codecov.
|
|
I feel like this one could probably just get merged with one review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Adds more detailed test coverage to
BulkLineItemsControlleractions, which are used to change line items in orders via the Bulk Order Management page.This spec includes taxes on line items, enterprise fees on both the order and on line items, taxes on those fees (both inherited and non-inherited), shipping and payment fees and taxes on shipping. It checks all of these things are correctly updated after the order is changed via BOM.
What should we test?
Green build, it's just specs.
Release notes
Increased test coverage on BulkLineItemsController
Changelog Category: Technical changes