Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rails 6.0] Fix problem in erb template by explicitly setting format to js #7566

Merged
merged 1 commit into from
May 15, 2021

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented May 6, 2021

What? Why?

In rails 6 the erb template is called with html and fails. We need to set format to js so the js.erb file is loaded.

What should we test?

I am not completely sure where this is used. I think this are the payment and shipment status on the admin order page.

Release notes

Changelog Category: Technical changes
Adapt code to rails 6

Dependencies

Documentation updates

@luisramos0 luisramos0 self-assigned this May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #7566 (de00022) into master (415d86b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7566   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         635      635           
  Lines       18136    18136           
=======================================
  Hits        16903    16903           
  Misses       1233     1233           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415d86b...de00022. Read the comment docs.

@andrewpbrett andrewpbrett added the dev-test A dev need to test this one label May 10, 2021
@andrewpbrett
Copy link
Contributor

Yes, it's on the admin order page. We can do a dev test to confirm that a completed order shows the correct payment state. That plus the green build should be sufficient.

@andrewpbrett
Copy link
Contributor

I tested this and the file is in fact rendered. I think this is fine to merge.

@andrewpbrett andrewpbrett merged commit f2c3b09 into openfoodfoundation:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-test A dev need to test this one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants