Spec customer creation during checkout #7443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simple order cycle factory was flexible enough already to work with given suppliers and distributors. We are now re-using that code so that you can pass these enterprises when creating a normal order cycle, too.
Expanding the controller spec with real data instead of mocks to test the real callback behaviours.
Codecov Report
@@ Coverage Diff @@
## master #7443 +/- ##
=======================================
Coverage 93.07% 93.08%
=======================================
Files 633 633
Lines 18148 18148
=======================================
+ Hits 16892 16893 +1
+ Misses 1256 1255 -1
Continue to review full report at Codecov.
|
|
This will come in handy to finish #7433. Let's see if we can merge it first. |
Matt-Yorkley
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Related to #6038.
I tried to replicate the issue of missing customer records and extended the specs. I didn't find the cause of the issue but the spec improvements are still worth merging. I'm testing the customer creation on controller level because that's where we are probably going to move the customer creation logic to (instead of callbacks in models).
The order cycle factory needed a bit of refactoring to create all the data needed for a checkout.
What should we test?
Just passing specs.
Release notes
Changelog Category: Technical changes
Improved test coverage of the checkout.