Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable customer_balance feature toggle to all users #7363

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Enable customer_balance feature toggle to all users #7363

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bac9f62
Enable customer_balance to all users
sauloperez Apr 9, 2021
95f29e4
Remove outdated initializer specs
sauloperez Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions config/initializers/feature_toggles.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
beta_testers = ENV['BETA_TESTERS']&.split(/[\s,]+/) || []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You keep this line just for the record?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove it in the same commit. So if we needed to revert this, it's done in one step.


OpenFoodNetwork::FeatureToggle.enable(:customer_balance) do |user|
if beta_testers == ['all']
true
else
beta_testers.include?(user.email)
end
!Rails.env.test?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me a bit uncomfortable...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too. It would have been good modify the specs in a way that they still pass. The simplest way would be to stub this method in related tests. That would make sure that all the other specs, which we think are not affected by this, are still passing and there is no surprising side effect.

end

OpenFoodNetwork::FeatureToggle.enable(:unit_price) do
Expand Down