Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing shipments controller spec #7356

Conversation

andrewpbrett
Copy link
Contributor

Another PR introduced a before_action to the controller, so we have to stub that out to avoid the double receiving an unexpected message

What? Why?

Gets the build back to green

What should we test?

Green build

Release notes

Fixed a failing shipments controller spec

Changelog Category: Technical changes

Dependencies

Documentation updates

Another PR introduced a before_action to the controller, so we have to stub that out to avoid the double receiving an unexpected message
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #7356 (5758a53) into master (9b3628a) will not change coverage.
The diff coverage is n/a.

❗ Current head 5758a53 differs from pull request most recent head c3c482c. Consider uploading reports for the commit c3c482c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7356   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files         635      635           
  Lines       18213    18213           
=======================================
  Hits        16939    16939           
  Misses       1274     1274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3628a...c3c482c. Read the comment docs.

@andrewpbrett andrewpbrett mentioned this pull request Apr 8, 2021
@Matt-Yorkley Matt-Yorkley merged commit d72cf18 into openfoodfoundation:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants