Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets feature toggle off on staging, by default #7350

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Apr 8, 2021

What? Why?

It sets feature toggles in staging environments to off, by default - thanks for the advice here @sauloperez 👍

Follows-up on the latest strategy around feature toggles - details here:
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Feature-toggles

What should we test?

We can check that features are toggled off, after staging pull-requests.

Release notes

Makes features toggled by default only for development environments.

Changelog Category: Technical changes

Dependencies

Documentation updates

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #7350 (25538a8) into master (b00828c) will not change coverage.
The diff coverage is n/a.

❗ Current head 25538a8 differs from pull request most recent head 4920db7. Consider uploading reports for the commit 4920db7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7350   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files         635      635           
  Lines       18206    18206           
=======================================
  Hits        16932    16932           
  Misses       1274     1274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00828c...4920db7. Read the comment docs.

Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

I'm wondering if that totally red Codecov report is because you branched off a really old master commit. Is that it?

@filipefurtad0
Copy link
Contributor Author

filipefurtad0 commented Apr 8, 2021

I don't think so Pau, I pulled the latest master and got:
HEAD is now at b00828cc4 Merge pull request #7311 from Matt-Yorkley/codecov-whitelisting
That should have done it, right?

@filipefurtad0 filipefurtad0 self-assigned this Apr 8, 2021
@filipefurtad0 filipefurtad0 added pr-staged-uk staging.openfoodnetwork.org.uk and removed pr-staged-uk staging.openfoodnetwork.org.uk labels Apr 8, 2021
@filipefurtad0
Copy link
Contributor Author

Ok, it seems to work.

To manually reactivate unit prices on staging, just replaced staging on the line:
Rails.env.development?

and restarting the server.

Good to go.

@Matt-Yorkley Matt-Yorkley merged commit 99265bb into openfoodfoundation:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants