Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rails 5.2] Fix base helper spec in rails 52 #7344

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

luisramos0
Copy link
Contributor

What? Why?

Fix helper in rails 5.2

What should we test?

Green helper

Release notes

Changelog Category: Technical changes
Adapt code to rails 5.2

Dependencies

Documentation updates

@luisramos0 luisramos0 self-assigned this Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #7344 (90a7ac9) into master (52c7abf) will not change coverage.
The diff coverage is n/a.

❗ Current head 90a7ac9 differs from pull request most recent head c33cf67. Consider uploading reports for the commit c33cf67 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7344   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files         649      649           
  Lines       18865    18865           
=======================================
  Hits        16923    16923           
  Misses       1942     1942           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c7abf...c33cf67. Read the comment docs.

@sauloperez sauloperez merged commit 27ac17f into openfoodfoundation:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants