-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove arrows on number input when adding items #7338
Remove arrows on number input when adding items #7338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7338 +/- ##
=======================================
Coverage 89.70% 89.70%
=======================================
Files 649 649
Lines 18865 18865
=======================================
Hits 16923 16923
Misses 1942 1942
Continue to review full report at Codecov.
|
c1f1304
to
d70c2b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👌
Hey @gucci-ninja , Also, this was checked for bulk buying items (the UI is slightly different): After your PR it looks fine: The weird looking line split is issue #7230, and not introduced here. Thanks so much! Good to go. |
What? Why?
Closes #7306
Previously when adding an item we were seeing the arrows displaying in the number input on Desktop Chrome/Safari/Edge. This change removes the arrows since we have plus/minus buttons.
On desktop:
Safari (fixed)
Firefox (no change)
Chrome (fixed)
What should we test?
Release notes
Changelog Category: User facing changes
Dependencies
Documentation updates