Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arrows on number input when adding items #7338

Conversation

gucci-ninja
Copy link
Contributor

What? Why?

Closes #7306

Previously when adding an item we were seeing the arrows displaying in the number input on Desktop Chrome/Safari/Edge. This change removes the arrows since we have plus/minus buttons.

On desktop:

  • Safari (fixed)
    safari

  • Firefox (no change)
    firefox

  • Chrome (fixed)
    chrome

What should we test?

  • UI fix, no tests needed

Release notes

  • Removes arrows showing up on number input on Chrome/Safari/Edge

Changelog Category: User facing changes

Dependencies

  • none

Documentation updates

  • none

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #7338 (1a18390) into master (1ce3103) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1a18390 differs from pull request most recent head d70c2b9. Consider uploading reports for the commit d70c2b9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7338   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files         649      649           
  Lines       18865    18865           
=======================================
  Hits        16923    16923           
  Misses       1942     1942           
Impacted Files Coverage Δ
lib/open_food_network/payments_report.rb 78.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce3103...d70c2b9. Read the comment docs.

@gucci-ninja gucci-ninja force-pushed the 7306-remove-arrows-from-number-input branch from c1f1304 to d70c2b9 Compare April 7, 2021 18:32
Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one! 🙏

Copy link
Contributor

@Matt-Yorkley Matt-Yorkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👌

@filipefurtad0 filipefurtad0 self-assigned this Apr 8, 2021
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Apr 8, 2021
@filipefurtad0
Copy link
Contributor

Hey @gucci-ninja ,

Firefox - as before
Peek 2021-04-08 13-53_

Chrome - OK
Peek 2021-04-08 13-53

Safari - OK
Peek 2021-04-08 13-55

iPhone
Peek 2021-04-08 13-57

Also, this was checked for bulk buying items (the UI is slightly different):

Peek 2021-04-08 14-00

After your PR it looks fine:

Peek 2021-04-08 14-03

The weird looking line split is issue #7230, and not introduced here.

Thanks so much! Good to go.

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Apr 8, 2021
@Matt-Yorkley Matt-Yorkley merged commit 704ed12 into openfoodfoundation:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop Chrome/Safari/Edge browsers display number input arrows when adding items (shopfront)
4 participants