Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCOTW: #ensure_updated_shipments #7316

Merged

Conversation

Matt-Yorkley
Copy link
Contributor

What? Why?

Dead code of the week: Spree::Order#ensure_updated_shipments

🔥

What should we test?

Green build.

Release notes

Removed unused code: Order#ensure_updated_shipments

Changelog Category: Technical changes

@Matt-Yorkley Matt-Yorkley self-assigned this Apr 3, 2021
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #7316 (0af01cc) into master (a014937) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0af01cc differs from pull request most recent head c895153. Consider uploading reports for the commit c895153 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7316      +/-   ##
==========================================
- Coverage   89.68%   89.68%   -0.01%     
==========================================
  Files         648      648              
  Lines       18849    18845       -4     
==========================================
- Hits        16905    16901       -4     
  Misses       1944     1944              
Impacted Files Coverage Δ
app/models/spree/order.rb 95.31% <ø> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a014937...c895153. Read the comment docs.

@sauloperez sauloperez merged commit a902230 into openfoodfoundation:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants