Add automated tests for unit price in backoffice #7260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibees
force-pushed
the
7069-add-automated-tests-for-unit-price-in-backoffice
branch
from
96dfc13 to
a96245b
Compare
mkllnk
reviewed
Mar 30, 2021
jibees
force-pushed
the
7069-add-automated-tests-for-unit-price-in-backoffice
branch
from
a96245b to
09c44f2
Compare
jibees
force-pushed
the
7069-add-automated-tests-for-unit-price-in-backoffice
branch
from
09c44f2 to
e9795ea
Compare
Codecov Report
@@ Coverage Diff @@
## master #7260 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 648 648
Lines 18849 18849
=======================================
Hits 16905 16905
Misses 1944 1944 Continue to review full report at Codecov.
|
|
Needs a rebase 👍 |
- Use `variant_unit_price` for `id` attribute and `variant[unit_price]` for `name` attribute - Previously, there was an duplicated `#id` on the page because we used `:price`
- So, `<label />` is rightly linked to its `<input />`
3 cases: - creating a new product - creating a new variant - editing an existing variant
jibees
force-pushed
the
7069-add-automated-tests-for-unit-price-in-backoffice
branch
from
e9795ea to
9126901
Compare
Done! |
andrewpbrett
approved these changes
Apr 3, 2021
There was a problem hiding this comment.
Looks good! Thanks @jibees. The build is green apart from the CodeCov check so I'm going to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This PR adds 3 tests for unit price in backoffice, for each 3 cases:
Closes #7069
What should we test?
Green build.
Release notes
Add automated tests for unit price in backoffice
Changelog Category: Technical changes