Better test InvoiceRenderer #7116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
force-pushed
the
increase-invoice-renderer-coverage
branch
2 times, most recently
from
56df336 to
1093287
Compare
This required a tiny refactoring to enable injecting the renderer. It'll make it easier to later add the relevant specs related to the order balance.
sauloperez
force-pushed
the
increase-invoice-renderer-coverage
branch
from
1093287 to
ae9d802
Compare
Matt-Yorkley
approved these changes
Mar 18, 2021
|
That failing spec is passing locally so I assume it's just flaky (I've seen quite a few times already). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This required a tiny refactoring to enable injecting the renderer. It'll make it easier to later add the relevant specs related to the order balance.
What should we test?
Green build.
Release notes
Better test InvoiceRenderer. This entails a tiny refactoring
Changelog Category: Technical changes