Only show primary producers on shopfront list of producers (fix #4218) #7015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
suggested changes
Mar 8, 2021
Matt-Yorkley
approved these changes
Mar 8, 2021
sauloperez
approved these changes
Mar 8, 2021
|
Hey @andrewpbrett , Before this PR:
The Hacienda and Hacienda Distributors are not producers (both are hubs); After this PR these are gone:
Cool, thanks for this fix! Good to go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #4218
This limits the list of producers on the shopfront Producers tab to those enterprises who are primary producers; that is, it does not show hub-only enterprises.
What should we test?
Enterprises that are hubs and not primary producers should not show up on that tab for a hub.
Release notes
Fixed a bug where non-producing enterprises would show up on the shopfront's list of producers.
Changelog Category: User facing changes
Dependencies
Documentation updates