New Product Form: Fill all space available #6807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two fields (Display As, and Unit Names) are mutually exclusive: they are never displayed at the same time. Use all the available space.
sauloperez
approved these changes
Feb 4, 2021
|
Thanks @jibees , I think it looks better this way, at least while there are no further changes to this page:
Looks good on desktop as well:
Ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #6798
Use all available space to display these two fields as they are mutually exclusive.
What should we test?
/admin/products/newItemsvalue forUNIT SIZEfield: there is no unused space on this lineUNIT SIZEfield: there is no unused space on this lineRelease notes
Fix a margin issue on new product form.
Changelog Category: User facing changes