[Rails 5] Update Angular CSRF handling #6685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-Yorkley
changed the title
luisramos0
approved these changes
Jan 19, 2021
sauloperez
approved these changes
Jan 19, 2021
|
Hey @Matt-Yorkley , After staging the PR, I checked pages which submit data asynchronously, like product bulk edit, inventory and bulk order management - all seems to work as before. Found this pre-existing issue, which behaves as before as well: #6399 Moving to ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Pulls in another piece from the Rails 5 upgrade #6635. Should be compatible with master.
Changes Angular CSRF token handling from the current (slightly hacky) method which pulls the token out of a tag in the DOM via jQuery, to a well-used gem made for handling CSRF tokens in Angular.
What should we test?
Form submissions that submit data asynchronously (without doing a full page reload). Admin bulk products is a good example.
Release notes
Updated Angular CSRF token handling for Rails 5
Changelog Category: Technical changes