Further fix #5989 (Item counter accepts values higher than the available stock) #6658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
sauloperez
approved these changes
Jan 15, 2021
|
Please, fill up the release notes section of the description 🙏 |
|
Hey @andrewpbrett , Thank you for this improvement! This now works fine, when editing or creating an order in the same window :
Typing a value higher than expected triggers this modal and adjusts the stock levels correctly 👍 Good to go! PS: Not introduced by this PR - Doing so in different windows breaks the order, if stock is exceeded and payments are added:
This causes an "Error saving payment". Clicking on "order details" then shows us our furry friend:
I think multi-tab / window is not supported on OFN, but this leads to corrupt orders which then need fixing - opening an issue on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #5989
In testing that PR, @filipefurtad0 noticed that it was still possible to manually fill in the quantity field and get the undesirable behavior. This prevents that from happening.
What should we test?
See #5989 (comment)
Release notes
Prevent the quantity field in the admin order screen from adding more than the available stock.
Changelog Category: User facing changes
Dependencies
Documentation updates