Image code tweaks #6509
Merged
Image code tweaks #6509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changed code obtains the image dimensions when you first upload an image. Unfortunately it's also triggered when thumbnails are refreshed. That doesn't change the size of the original image though.
If you ran only the second spec without the first, the rake file wasn't loaded and the test failed.
|
Hey @mkllnk , I'll rebuild and check if it's gone after that 👍 |
|
Ok, rebuilt this PR: the previously failing spec passed, and another one failed -> i.e., flaky specs... Checked:
This looks got to go. Thanks @mkllnk 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Follow up from #6014. The main scripts in that PR are not needed any more but I extracted a few tweaks that should improve code style and catch some edge cases.
All commits in this PR have been reviewed before. So I'll skip review and put this straight into test-ready.
What should we test?
Upload a product image and verify that it displays in the shop.
Release notes
Changelog Category: Technical changes
Image maintenance scripts are more robust now.