Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump delayed_job_active_record from 4.1.4 to 4.1.5 #6503

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2020

Bumps delayed_job_active_record from 4.1.4 to 4.1.5.

Commits
  • 001b246 Prepare 4.1.5 release
  • 39b739b Merge pull request #184 from collectiveidea/dg-rails-6-1
  • 9bcaa27 Correct legacy database adapter versions
  • 3d6f9f7 Add Rails 6.1 to biuld grid
  • d88886e Allow rails 6.1
  • c459b7c Rely on latest jdbc code for edge testing
  • cf6f864 Updated jdbc adapters were released
  • 3954b43 Merge pull request #183 from collectiveidea/dg-move-to-github-actions
  • b4686bb Update readme badge
  • 187ee42 Remove travis config
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Dec 9, 2020
Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to test subscriptions and emails sent with delayed job, we can test just a few, for example, order placement and order cancelation.

@filipefurtad0 filipefurtad0 self-assigned this Dec 10, 2020
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Dec 10, 2020
@filipefurtad0
Copy link
Contributor

Hi @andrewpbrett and Luis,

All good here:

  • placed subscriptions and received all related emails

    • subscription confirmation email
    • order placement email
    • failed payment email
    • order placement summary email (to the shop owner)
    • confirmation summary email (to the shop owner)
  • placed a regular order (shopfront)

  • shipped an order (BO)

  • cancelled an order (BO)

All emails arrived as expected - moving to ready to go.

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Dec 10, 2020
@sauloperez sauloperez merged commit 3bf58b5 into master Dec 10, 2020
@sauloperez sauloperez deleted the dependabot/bundler/delayed_job_active_record-4.1.5 branch December 10, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants