Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab toggle #6455

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Fix tab toggle #6455

merged 1 commit into from
Dec 14, 2020

Conversation

arku
Copy link
Contributor

@arku arku commented Dec 4, 2020

What? Why?

Closes #6265

What should we test?

Make sure switching tabs work fine. If you click on the active tab, nothing should happen.

Release notes

Changelog Category: User facing changes | Technical changes

Dependencies

Documentation updates

andrewpbrett
andrewpbrett approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@andrewpbrett andrewpbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works! I'm not really fluent with Angular, or familiar with the history for why those additional lines may have been there, so I don't know if there are any side effects that I'm missing, but I think it's fine to merge.

@filipefurtad0 filipefurtad0 self-assigned this Dec 13, 2020
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Dec 13, 2020
@filipefurtad0
Copy link
Contributor

Hey @arku ,

I tried this an it looks good: Clinking repeatedly on the active tabs does close-open them repeatedly, as reported in the issue.
I could not any other behavior throughout the app which is affected by this PR, other than the /account# pages.

Looks good to go - thanks for this fix!

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Dec 13, 2020
@sauloperez sauloperez merged commit 9f517e1 into openfoodfoundation:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauloperez sauloperez sauloperez approved these changes

@andrewpbrett andrewpbrett andrewpbrett approved these changes

Assignees

@arku arku

@filipefurtad0 filipefurtad0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking the current tab on the Account page hides that tab
4 participants
@arku @filipefurtad0 @andrewpbrett @sauloperez