Upgrade to devise 4.7 #6438
Merged
Upgrade to devise 4.7 #6438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
approved these changes
Dec 2, 2020
|
Hey @luisramos0 , Staged this PR and tested the
workflows, checking the respective emails - nothing unusual, all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes https://github.com/openfoodfoundation/ofn-security/issues/22
This test_after_commit gem was needed to make it work in specs:
https://github.com/heartcombo/devise/blob/master/CHANGELOG.md#410
What should we test?
We need to verify all user workflows: signup, registration, password change and all related emails.
Release notes
Changelog Category: Technical changes
Upgraded devise, the dependency that handles user authentication in OFN.