When searching for shop products check the variant :display_name and :display_as fields too #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:display_as fields too. Fixes openfoodfoundation#5757
|
Hey @cillian , I had a look this before and after the PR. Before staging:
After staging: Did a brief sanity check on the search field on openstreet maps as well - these search fields are related in the app, right? - all good here as well. Thank you for this fix! Ready to go. PS: I was unaware of the "Pending" status one can attribute to certain test cases. Interesting! |
|
Hey @filipefurtad0 the OSM search map shouldn't be affected from this change but thanks for checking anyway 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #5757
What should we test?
See Steps to Reproduce in #5757
Release notes
Fix shop product search so it finds products by their variant names too.
Changelog Category: Fixed