Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace build with build_stubbed in flexi rate and per item model specs #6078

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Replace build with build_stubbed in flexi rate and per item model specs #6078

merged 2 commits into from
Sep 24, 2020

Conversation

arku
Copy link
Contributor

@arku arku commented Sep 22, 2020

What? Why?

Related to #6062

Replaces FactoryBot::Syntax::Methods#build calls with FactoryBot::Syntax::Methods#build_stubbed in Calculator::FlexiRate and Calculator::PerItem model specs to improve the test suite performance.

What should we test?

Release notes

Improve specs' performance.

Changelog Category: Added | Changed | Deprecated | Removed | Fixed | Security

Discourse thread

Dependencies

Documentation updates

Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@luisramos0 luisramos0 merged commit e04b85e into openfoodfoundation:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants