Replace create with build_stubbed in address model specs
#6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is weird. The model specs pass locally 😕 |
|
ah, yes, there's something I cant understand with this spec. I struggled here recently when moving some code from spree. |
luisramos0
suggested changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Related to #6062
We don't need objects in the database for the unit tests most of the time. This PR replaces
FactoryBot::Syntax::Methods#createcalls withFactoryBot::Syntax::Methods#build_stubbedin theAddressmodel specs wherever possible.What should we test?
Release notes
Changelog Category: Added | Changed | Deprecated | Removed | Fixed | Security
Discourse thread
Dependencies
Documentation updates