Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash error issues in checkout requests #5906

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Fix flash error issues in checkout requests #5906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de22ad0
Fix flash error issues in checkout requests
Matt-Yorkley Aug 14, 2020
0fd1636
Rename method for clarity
Matt-Yorkley Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/controllers/checkout_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ def action_failed_response
render :edit
end
format.json do
discard_flash_errors
render json: { errors: @order.errors, flash: flash.to_hash }.to_json, status: :bad_request
end
end
Expand All @@ -248,4 +249,11 @@ def rescue_from_spree_gateway_error(error)
def permitted_params
PermittedAttributes::Checkout.new(params).call
end

def discard_flash_errors
# Marks flash errors for deletion after the current action has completed.
# This ensures flash errors generated during XHR requests are not persisted in the
# session for longer than expected.
flash.discard(:error)
end
end